[Top] [All Lists]

Re: Review: Don't use kmap() in xfs_iozero().

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Review: Don't use kmap() in xfs_iozero().
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Feb 2007 18:06:14 +0000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20070202133941.GW33919298@xxxxxxxxxxxxxxxxx>
References: <20070202054044.GO33919298@xxxxxxxxxxxxxxxxx> <20070202114830.GB23187@xxxxxxxxxxxxx> <20070202133941.GW33919298@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/
On Sat, Feb 03, 2007 at 12:39:41AM +1100, David Chinner wrote:
> Even on 64 bit platforms? I just added an explicit cast as a matter
> of avoiding potential gcc warnings on other platforms/compiler
> versions. Maybe I'm just being paranoid and I can remove it?

Yes, it's fine on 64bit platforms aswell - I just built my equivalent
buffer.c changes on 64bit powerpc and we have lots of similar cases
all over the tree.

<Prev in Thread] Current Thread [Next in Thread>