| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: Don't use kmap() in xfs_iozero(). |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 2 Feb 2007 11:48:30 +0000 |
| Cc: | xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20070202054044.GO33919298@melbourne.sgi.com> |
| References: | <20070202054044.GO33919298@melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.2i |
On Fri, Feb 02, 2007 at 04:40:44PM +1100, David Chinner wrote: > kmap is inefficient and does scale well. kmap_atomic() is a better > choice. Use the generic wrapper function instead of open coding the > kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton. > > Comments? Looks good. > + memclear_highpage_flush(page, (unsigned int)offset, bytes); Do you need the cast here? An unsigned long should be automatically demoted to an unsigned int when passing it as an argument. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: freezing sometimes leaves the log dirty, Christoph Hellwig |
|---|---|
| Next by Date: | Re: Review: Don't use kmap() in xfs_iozero()., David Chinner |
| Previous by Thread: | Review: Don't use kmap() in xfs_iozero()., David Chinner |
| Next by Thread: | Re: Review: Don't use kmap() in xfs_iozero()., David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |