| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2]: Fix BUG in cancel_dirty_pages on XFS |
| From: | Nick Piggin <nickpiggin@xxxxxxxxxxxx> |
| Date: | Thu, 25 Jan 2007 21:26:22 +1100 |
| Cc: | Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxx |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:X-YMail-OSG:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=VNh/3AsBVfNWk7QyYg27s1mfmOyBgaAXMxco5kLv+Lo7oUk5NGFtMP+Wh3QzvaL2WjiWP0Zb5XTcZuCnIdj7epc9a0+LkLJEn7AiwZWytUzsctoIkgW3Hriw3uZLyCjOrTU2wxbSL9R5txZ6a/NGbI+HHgTB6S529Wton/2t2FA= ; |
| In-reply-to: | <20070125074018.GB33919298@xxxxxxxxxxxxxxxxx> |
| References: | <1169640835.6189.14.camel@twins> <45B7627B.8050202@xxxxxxxxxxxx> <20070124224654.GN33919298@xxxxxxxxxxxxxxxxx> <45B7F5F9.2070308@xxxxxxxxxxxx> <20070125003536.GS33919298@xxxxxxxxxxxxxxxxx> <45B7FE1C.3070807@xxxxxxxxxxxx> <20070125015204.GV33919298@xxxxxxxxxxxxxxxxx> <45B80F65.6010206@xxxxxxxxxxxx> <20070125034227.GX33919298@xxxxxxxxxxxxxxxxx> <45B83139.1040007@xxxxxxxxxxxx> <20070125074018.GB33919298@xxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 |
David Chinner wrote: Only if we leave the page in the page cache. If we toss the page, the time it takes to do the I/O for the page fault is enough for the direct I/o to complete. Sure it's not an absolute guarantee, but if you want an absolute guarantee: So I guess you *could* relax it in theory... Anyway, don't take my pestering as advocacy for wanting XFS to do something more clever in such a corner case. I think you're quite right to be conservative and share codepaths between direct IO read and write. -- SUSE Labs, Novell Inc.Send instant messages to your online friends http://au.messenger.yahoo.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.20-rc5: cp 18gb 18gb.2 = OOM killer, reproducible just like 2.16.19.2, Justin Piszcz |
|---|---|
| Next by Date: | Re: 2.6.20-rc5: cp 18gb 18gb.2 = OOM killer, reproducible just like 2.16.19.2, Justin Piszcz |
| Previous by Thread: | Re: [PATCH 1/2]: Fix BUG in cancel_dirty_pages on XFS, David Chinner |
| Next by Thread: | Re: [PATCH 1/2]: Fix BUG in cancel_dirty_pages on XFS, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |