xfs
[Top] [All Lists]

Re: Review: fix block reservation to work with per-cpu counters

To: xfs@xxxxxxxxxxx
Subject: Re: Review: fix block reservation to work with per-cpu counters
From: Kevin Jamieson <kjamieson@xxxxxxxxxx>
Date: Mon, 15 Jan 2007 13:31:22 -0800
Organization: Bycast
Reply-to: kjamieson@xxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Icedove 1.5.0.9 (X11/20061220)
This fails to build on non-SMP systems:

 CC [M]  fs/xfs/xfs_fsops.o
fs/xfs/xfs_fsops.c: In function 'xfs_fs_counts':
fs/xfs/xfs_fsops.c:463: warning: implicit declaration of function 
'xfs_icsb_sync_counters_flags'
fs/xfs/xfs_fsops.c:463: error: 'XFS_ICSB_LAZY_COUNT' undeclared (first use in 
this function)
fs/xfs/xfs_fsops.c:463: error: (Each undeclared identifier is reported only once
fs/xfs/xfs_fsops.c:463: error: for each function it appears in.)
fs/xfs/xfs_fsops.c: In function 'xfs_reserve_blocks':
fs/xfs/xfs_fsops.c:525: error: 'XFS_ICSB_SB_LOCKED' undeclared (first use in 
this function)
make[1]: *** [fs/xfs/xfs_fsops.o] Error 1
make: *** [fs/xfs/xfs.ko] Error 2


The define for not HAVE_PERCPU_SB needs to be changed:


Index: fs/xfs/xfs_mount.h
===================================================================
RCS file: /cvs/linux-2.6-xfs/fs/xfs/xfs_mount.h,v
retrieving revision 1.232
diff -u -r1.232 xfs_mount.h
--- fs/xfs/xfs_mount.h  10 Jan 2007 14:42:52 -0000      1.232
+++ fs/xfs/xfs_mount.h  15 Jan 2007 21:13:09 -0000
@@ -311,7 +311,7 @@

#else
#define xfs_icsb_init_counters(mp)      (0)
-#define xfs_icsb_sync_counters_lazy(mp)        do { } while (0)
+#define xfs_icsb_sync_counters_flags(mp, flags)        do { } while (0)
#endif

typedef struct xfs_mount {



<Prev in Thread] Current Thread [Next in Thread>