Re: Review: fix mapping invalidation callouts

[David Chinner <dgc@xxxxxxx>]

On Tue, Jan 09, 2007 at 11:57:38AM +0000, Lachlan McIlroy wrote:
> 
> This patch fixes fs_tosspages() and fs_flushinval_pages() but will a
> call to fs_flush_pages() with flags including B_INVAL work correctly?

By definition fs_flush_pages() only flushes pages. If you need
to flush and invalidate pages, you use fs_flushinval_pages().

Passing B_INVAL to fs_flush_pages() is broken code.

> I can't see any code that passes B_INVAL into fs_flush_pages()

good ;)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group