On Mon, Jan 08, 2007 at 09:09:16AM +0000, Christoph Hellwig wrote:
> On Mon, Jan 08, 2007 at 03:03:09PM +1100, David Chinner wrote:
> > With the recent cancel_dirty_page() changes, a warning was
> > added if we cancel a dirty page that is still mapped into
> > the page tables.
> > This happens in XFS from fs_tosspages() and fs_flushinval_pages()
> > because they call truncate_inode_pages().
> >
> > truncate_inode_pages() does not invalidate existing page mappings;
> > it is expected taht this is called only when truncating the file
> > or destroying the inode and on both these cases there can be
> > no mapped ptes. However, we call this when doing direct I/O writes
> > to remove pages from the page cache. As a result, we can rip
> > a page from the page cache that still has mappings attached.
> >
> > The correct fix is to use invalidate_inode_pages2_range() instead
> > of truncate_inode_pages(). They essentially do the same thing, but
> > the former also removes any pte mappings before removing the page
> > from the page cache.
> >
> > Comments?
>
> Generally looks good. But I feel a little cautios about changes in this
> area, so we should throw all possible test loads at this before commiting
> it.
Yup - fsx is one test that I really want to hit with this. The guy that
reported the initial problem has replied saying this patch fixes the
warnings (good start ;), but I'll hold off pushing it for a little
while to test it more. This (or something like it) will need to go
into 2.6.20 before it is released so we've got limited time to
test this one out....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|