xfs
[Top] [All Lists]

Re: Review: fix block reservation to work with per-cpu counters

To: Kevin Jamieson <kjamieson@xxxxxxxxxx>
Subject: Re: Review: fix block reservation to work with per-cpu counters
From: David Chinner <dgc@xxxxxxx>
Date: Tue, 16 Jan 2007 10:47:10 +1100
Cc: xfs@xxxxxxxxxxx, chatz@xxxxxxx
In-reply-to: <45ABF2AA.2010209@bycast.com>
References: <45ABF2AA.2010209@bycast.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Mon, Jan 15, 2007 at 01:31:22PM -0800, Kevin Jamieson wrote:
> This fails to build on non-SMP systems:
> 
>  CC [M]  fs/xfs/xfs_fsops.o
> fs/xfs/xfs_fsops.c: In function 'xfs_fs_counts':
> fs/xfs/xfs_fsops.c:463: warning: implicit declaration of function 
> 'xfs_icsb_sync_counters_flags'
> fs/xfs/xfs_fsops.c:463: error: 'XFS_ICSB_LAZY_COUNT' undeclared (first use 
> in this function)
> fs/xfs/xfs_fsops.c:463: error: (Each undeclared identifier is reported only 
> once
> fs/xfs/xfs_fsops.c:463: error: for each function it appears in.)
> fs/xfs/xfs_fsops.c: In function 'xfs_reserve_blocks':
> fs/xfs/xfs_fsops.c:525: error: 'XFS_ICSB_SB_LOCKED' undeclared (first use 
> in this function)
> make[1]: *** [fs/xfs/xfs_fsops.o] Error 1
> make: *** [fs/xfs/xfs.ko] Error 2
> 
> 
> The define for not HAVE_PERCPU_SB needs to be changed:

Sorry about that - my fault. This fix looks good - I'll try to find some
time to check this in (I'm at LCA right now and have limited net
access).

Chatz, maybe you could check this in?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>