| To: | Barry Naujok <bnaujok@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Return failure error if something fails in xfs_growfs |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Thu, 21 Dec 2006 10:37:19 -0600 |
| Cc: | xfs-dev@xxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <200612210609.RAA24334@xxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <200612210609.RAA24334@xxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 1.5.0.8 (X11/20061107) |
Barry Naujok wrote: > A very simple patch that return error rather than success if something > fails in xfs_growfs. > > Barry. Try as I might to follow the grand linux tradition of finding some minor stylistic point to complain about (whitespace, formatting, choice of variable names, etc) I could not. So, looks good to me. :-) -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: Clear unwritten flag on during partial page truncation, David Chinner |
|---|---|
| Next by Date: | [PATCH] remove unused "firstblock" arg from xfs_bmap_finish(), Eric Sandeen |
| Previous by Thread: | Re: [PATCH] Return failure error if something fails in xfs_growfs, Nathan Scott |
| Next by Thread: | PARTIAL TAKE 957103 - Merge 2.6.x-xfs up to more recent kernels and new kdb versions, Donald Douwsma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |