| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: Fix use after free on forced shutdown |
| From: | Lachlan McIlroy <lachlan@xxxxxxx> |
| Date: | Wed, 20 Dec 2006 08:49:01 +0000 |
| Cc: | xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20061219053012.GY33919298@xxxxxxxxxxxxxxxxx> |
| Organization: | SGI |
| References: | <20061219053012.GY33919298@xxxxxxxxxxxxxxxxx> |
| Reply-to: | lachlan@xxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.7.12) Gecko/20050920 |
Fix looks good to me. David Chinner wrote: As found earlier today trying to reproduce a different use after free, a machine with CONFIG_SLAB_DEBUG will panic on a forced shutdown if the inode has an assocaited item in the AIL. Trivial fix is to remove the item from the AIL before freeing it. Cheers, Dave. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: Clear unwritten flag on during partial page truncation, Lachlan McIlroy |
|---|---|
| Next by Date: | Re: Review: Clear unwritten flag on during partial page truncation, David Chinner |
| Previous by Thread: | Review: Fix use after free on forced shutdown, David Chinner |
| Next by Thread: | TAKE 959034 - Fix debian breakage with last attr patch, Barry Naujok |
| Indexes: | [Date] [Thread] [Top] [All Lists] |