xfs
[Top] [All Lists]

Re: [PATCH] use vfs-defined file attribute flags

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] use vfs-defined file attribute flags
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 14 Dec 2006 12:18:55 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20061214181500.GA13856@xxxxxxxxxxxxx>
References: <45819221.70502@xxxxxxxxxxx> <20061214181500.GA13856@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20061107)
Christoph Hellwig wrote:
>> -#define LINUX_XFLAG_SYNC    0x00000008 /* Synchronous updates */
>> -#define LINUX_XFLAG_IMMUTABLE       0x00000010 /* Immutable file */
>> -#define LINUX_XFLAG_APPEND  0x00000020 /* writes to file may only append */
>> -#define LINUX_XFLAG_NODUMP  0x00000040 /* do not dump file */
>> -#define LINUX_XFLAG_NOATIME 0x00000080 /* do not update atime */
>> +#define LINUX_XFLAG_SYNC    FS_SYNC_FL      /* Synchronous updates */
>> +#define LINUX_XFLAG_IMMUTABLE       FS_IMMUTABLE_FL /* Immutable file */
>> +#define LINUX_XFLAG_APPEND  FS_APPEND_FL    /* writes may only append */
>> +#define LINUX_XFLAG_NODUMP  FS_NODUMP_FL    /* do not dump file */
>> +#define LINUX_XFLAG_NOATIME FS_NOATIME_FL   /* do not update atime */
> 
> Just kill the defines completly and use the FS_ flags.

that probably would be better, I thought of that after I sent it. :)

*shrug* whichever.  It's heresy to suggest less indirection in xfs ;-)

-Eric


<Prev in Thread] Current Thread [Next in Thread>