xfs
[Top] [All Lists]

Re: TAKE 956783 - xfs_dm_getall_dmattr() doesn't check if the user buffe

To: Vlad Apostolov <vapo@xxxxxxx>
Subject: Re: TAKE 956783 - xfs_dm_getall_dmattr() doesn't check if the user buffer is at valid address
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 29 Nov 2006 15:11:46 +0000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, sgi.bugs.xfs@xxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <456B7C1A.90209@xxxxxxx>
References: <45629AD8.8000800@xxxxxxx> <20061127055859.GC1374@xxxxxxxxxxxxx> <456B7C1A.90209@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Tue, Nov 28, 2006 at 11:00:26AM +1100, Vlad Apostolov wrote:
> The fix is actually fine as it gives an early indication (even not complete)
> that the user pointer is bad. There is another problem you are pointing at 
> and it is the userspace pointer dereference later on without using 
> copy_to_user(). If you have any patch fixing this problem it would be great.

Unfortunately I haven't found my patch, I'm sorry.  I have on the other
hand found various old trivial XFS patches of mine that I'll submit.


<Prev in Thread] Current Thread [Next in Thread>