xfs
[Top] [All Lists]

Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 16 Nov 2006 16:55:36 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20061116224527.GF11034@xxxxxxxxxxxxxxxxx>
References: <455CB54F.8080901@xxxxxxxxxxx> <20061116224527.GF11034@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20061107)
David Chinner wrote:

> The real bug here was whoever removed the dummy field and did not
> replace that with a comment ot say that the xfs_sb strucutre needs
> to be padded to 64 bits to ensure translation worked properly
> on 64 bit systems.
> 
> I'd prefer explicit padding (with warning comments) over packing
> the structure. Thoughts?

yes, I agree that explicit padding, and a comment about why it's there,
would be better.

I was thinking about this over lunch and meant to follow up, but then
figured out that the actual bug isn't because of this (it's broken as
well on x86), and kept trying to chase that :)

-Eric


<Prev in Thread] Current Thread [Next in Thread>