xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] remove unused filp from ioctl functions

from [Christoph Hellwig] [Permanent Link][Original]
To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] remove unused filp from ioctl functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 11 Nov 2006 10:56:27 +0000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4555437B.4040904@xxxxxxxxxxx>
References: <4555437B.4040904@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i 
On Fri, Nov 10, 2006 at 09:28:59PM -0600, Eric Sandeen wrote:
> There's a stuct file * passed around the ioctl code that is never
> used... just takes up precious stack space near as I can tell :)

While you're at it kill the inode paramater anyway, it can be retrieved
from the vnode by trivial address arithmetics.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: XFS filesystem performance drop in kernels 2.6.16+, Jan Engelhardt
Next by Date:  Re: [PATCH] remove unused filp from ioctl functions, Eric Sandeen
Previous by Thread:  [PATCH] remove unused filp from ioctl functions, Eric Sandeen
Next by Thread:  Re: [PATCH] remove unused filp from ioctl functions, Eric Sandeen
Indexes:  [Date] [Thread] [Top] [All Lists]