[Top] [All Lists]

Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches
From: Russell Cattelan <cattelan@xxxxxxxxxxx>
Date: Tue, 21 Nov 2006 19:02:16 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <45627A4D.3020502@sandeen.net>
References: <455CB54F.8080901@sandeen.net> <455CE1E3.7020703@sandeen.net> <45612621.5010404@sandeen.net> <45627A4D.3020502@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
On Mon, 2006-11-20 at 22:02 -0600, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > Eric Sandeen wrote:
> >   
> >> ugh.  it's broken on x86 too, so it's not just the alignment/padding,
> >>     
> >> although that should be fixed for cross-arch mounts.
> >>     
> >> -Eric
> >>     
> >>     
> > here's a testcase to corrupt it FWIW.
> >   
> >   
> Ok, with expert collaboration from Russell, Barry, Tim, 
> Nathan, David, et al, how about this:
> For btree dirs, we need a different calculation for the space
> used in di_u, to set the minimum threshold for the fork offset...
> This fixes my testcase, but as Tim points out -now- we need to compact
> the btree ptrs, if we return (and use) an offset < current forkoff...
> whee....
> -Eric
It turns out this only fixes one of the problems it is still quite easy 
to corrupt indoes with attr2.

The following patch is a short term fix that address the problem of
moving without re-factoring the root inode btree root block.

Once the inode has be flipped to BTREE for the data space the forkoff is
to the that size, currently due to the way attr1 worked (fixed size
forkoff) the code is not handling the size to the root btree node due to
size changes in the attr portion of the inode.

The optimal solution is to adjust the data portion of the inode root
btree block down if space exists.

One easy fix that was resulting all attr add being pushed out of line is
the header size to the initial split of the inode, at least the first
attr add
should go inline now. Which should be a win the big attr user right now 

Including the 2 test script that have been used.

Russell Cattelan <cattelan@xxxxxxxxxxx>

Attachment: attr2_patch
Description: Text Data

Attachment: r2.sh
Description: application/shellscript

Attachment: e2
Description: application/shellscript

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>