xfs
[Top] [All Lists]

Re: [PATCH/RFC] pass dio_complete proper offset from finished_one_bio

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH/RFC] pass dio_complete proper offset from finished_one_bio
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Tue, 28 Nov 2006 08:09:50 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, rtc@xxxxxx
In-reply-to: <45691753.60500@redhat.com>
References: <45691753.60500@redhat.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (Macintosh/20061025)
Eric Sandeen wrote:
We saw problems w/ xfs doing AIO+DIO into a sparse file.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217098

It seemed that xfs was doing "extent conversion" at the wrong offsets, so
written regions came up as unwritten (zeros) and stale data was exposed
in the region after the write.  Thanks to Peter Backes for the very
nice testcase.

This also broke xen with blktap over xfs.

Hrmph. Zach's changes in -mm magically made this go away... I was about to submit a proper patch against -mm but it seem to be not needed.


So, now digging around to see why that is, and what exactly "fixed" things.

-Eric


<Prev in Thread] Current Thread [Next in Thread>