Re: [PATCH 1/2] Make stuff static

[Nathan Scott <nscott@xxxxxxxxxx>]

On Tue, 2006-10-17 at 13:09 +1000, David Chinner wrote:
> On Mon, Oct 16, 2006 at 08:03:47PM -0500, Eric Sandeen wrote:
> > David Chinner wrote:
> > 
> Of course, no plan ever survives contact with the enemy. :/
> 
> STATIC is also used for defining various structure tables.
> And variables.  They'll all get changed to "static"....
> 
> Then there's __inline and __inline__ still used in places.....
> 
> The patch that follows does the noinline change, de-inlines
> xfs_cleanup_inode() and cleans up all the inline cruft hanging around.
> 
> Comments?
> 

Be careful of userspace, where much of this code is also compiled in
libxfs, and STATIC is always #defined away to nothingness there (as
there's need for some routines to be accessed outside of one source
file there, differently to the kernel, IIRC).

cheers.

-- 
Nathan