Hi Roger,
Just to let you know, I now have a filesystem that is displaying this
warning, so I am looking into it in combination with your patch. I'll let
you know how it goes.
Regards,
Barry.
> -----Original Message-----
> From: xfs-bounce@xxxxxxxxxxx [mailto:xfs-bounce@xxxxxxxxxxx]
> On Behalf Of Roger Willcocks
> Sent: Wednesday, 13 September 2006 2:23 AM
> To: xfs@xxxxxxxxxxx
> Subject: LEAFN node level is N -- bogus warning
>
> In xfs_repair / dir2.c there's a check for the 'level' of a
> directory leaf node within the btree hierarchy. A warning
> 'LEAFN node level is N' is generated if the level >= 1.
>
> But leaf nodes don't have a /level/ member, although internal
> nodes do (compare xfs_dir2_leaf_hdr_t and xfs_da_intnode_t).
> xfs_repair is actually testing leaf->hdr.stale - so the
> warning is bogus.
>
> The attached patch removes the test and make the relationship
> between magic numbers and pointer types more explicit.
>
> --
> Roger
>
>
>
|