xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 1/2] Make stuff static

from [Eric Sandeen] [Permanent Link][Original]
To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH 1/2] Make stuff static
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 16 Oct 2006 20:03:47 -0500
Cc: Russell Cattelan <cattelan@xxxxxxxxxxx>, Timothy Shimmin <tes@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20061017005038.GN11034@xxxxxxxxxxxxxxxxx>
References: <20060929032856.8DA9C18001A5E@xxxxxxxxxxx> <23F15D6AE8566A54B81188AC@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <45338DDE.8020903@xxxxxxxxxxx> <4533FAEA.2080500@xxxxxxxxxxx> <20061016232250.GM11034@xxxxxxxxxxxxxxxxx> <1161042943.5723.117.camel@xxxxxxxxxxxxxxxxxxxx> <20061017005038.GN11034@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.7 (Macintosh/20060909) 
David Chinner wrote:


So you are proposing?
/* non-debug */
#define STATIC static inline
/* debug */
#define STATIC noinline


No.

Currently STATIC is defined in fs/xfs/support/debug.h as:

#ifndef STATIC
#define STATIC static
#endif

I'm proposing that gets changed to:


#define STATIC static noinline


This.


This sounds reasonable to me, David.

-Eric
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 1/2] Make stuff static, David Chinner
Next by Date:  RE: LEAFN node level is N -- bogus warning, Barry Naujok
Previous by Thread:  Re: [PATCH 1/2] Make stuff static, David Chinner
Next by Thread:  Re: [PATCH 1/2] Make stuff static, David Chinner
Indexes:  [Date] [Thread] [Top] [All Lists]