| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Data type overflow in xfs_trans_unreserve_and_mod_sb |
| From: | Shailendra Tripathi <stripathi@xxxxxxxxx> |
| Date: | Fri, 13 Oct 2006 14:01:27 +0530 |
| Cc: | sandeen@xxxxxxxxxxx, xfs@xxxxxxxxxxx, Timothy Shimmin <tes@xxxxxxx> |
| In-reply-to: | <20061013061354.GF19345@xxxxxxxxxxxxxxxxx> |
| References: | <55EF1E5D5804A542A6CA37E446DDC206655888@xxxxxxxxxxxxxxxxxxxxxx> <45179573.3020007@xxxxxxxxx> <20061011052557.GM19345@xxxxxxxxxxxxxxxxx> <20061013061354.GF19345@xxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla Thunderbird 0.9 (X11/20041127) |
David Chinner wrote: Eric, you suggested specific 64 bit types - I think that's really the way to fix this, but it's a much bigger change...Shailendra, here's a patch that passes XFSQA that changes this all to 64 bit types. I've had to fix various type abuses that weren't obvious because gcc fails to warn when you pass a uint into a function parameter that is declared as int64_t.....I haven't tested the >2TB grow case yet, but it should work now on both 32bit and 64 bit platforms with this patch.Is there anything I missed here in the conversion? Cheers, Dave. Looks ok to me, Dave. Thanks. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch] Fix xfs_iunpin() sets I_DIRTY_SYNC after clear_inode()., Timothy Shimmin |
|---|---|
| Next by Date: | aloha, WinniejdsFinkgft@xxxxxxxxxxxxx |
| Previous by Thread: | Re: Data type overflow in xfs_trans_unreserve_and_mod_sb, David Chinner |
| Next by Thread: | Software raid 5 with XFS causing strange lockup problems, Ian Williamson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |