|To:||David Chinner <dgc@xxxxxxx>|
|Subject:||Re: review: xfs_copy fix|
|From:||Timothy Shimmin <tes@xxxxxxx>|
|Date:||Fri, 06 Oct 2006 17:15:24 +1000|
Hi Dave, --On 6 October 2006 4:36:43 PM +1000 David Chinner <dgc@xxxxxxx> wrote:
On Fri, Oct 06, 2006 at 04:18:10PM +1000, Timothy Shimmin wrote:Request for review. xfs_copy was seg faulting for me on my x86_64 box. This fixes up the variable arg handling for multiple vfprintf calls by putting va_start and va_end calls around them (never done this before:).I take it that it was crashing because the LOG flag and one of ERR or OUT was set so it was trying to do 2 varargs traversals with only one init?
Exactly. In the case I tried, it had LOG and OUT flags on, from memory.
Looks sane to me.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: review: set blocksize patch - libxfs & mkfs, David Chinner|
|Next by Date:||Re: review: set blocksize patch - libxfs & mkfs, Timothy Shimmin|
|Previous by Thread:||Re: review: xfs_copy fix, David Chinner|
|Next by Thread:||review: set blocksize patch - libxfs & mkfs, Timothy Shimmin|
|Indexes:||[Date] [Thread] [Top] [All Lists]|