| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: clean up inode i_flags handling |
| From: | Nathan Scott <nscott@xxxxxxxxxx> |
| Date: | Wed, 04 Oct 2006 09:58:50 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1159914373.32536.9.camel@edge> |
| Organization: | Aconex |
| References: | <20061003051325.GR4695059@xxxxxxxxxxxxxxxxx> <1159914373.32536.9.camel@edge> |
| Reply-to: | nscott@xxxxxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Wed, 2006-10-04 at 08:26 +1000, Nathan Scott wrote: > On Tue, 2006-10-03 at 15:13 +1000, David Chinner wrote: > > > > This part seems like overkill, I'd just do that inline like the clear > variant, since its just one instruction ... > ..but I guess you did it for consistency, as that one instruction is otherwise going to have to be open coded in a few places ... *shrug* looks good to me either way. cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: prevent deadlock via async iput from xfs_iunpin, Nathan Scott |
|---|---|
| Next by Date: | Re: [RFC 0/3] Convert XFS inode hashes to radix trees, Chris Wedgwood |
| Previous by Thread: | Re: Review: clean up inode i_flags handling, Nathan Scott |
| Next by Thread: | [RFC 0/3] Convert XFS inode hashes to radix trees, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |