| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: prevent deadlock via async iput from xfs_iunpin |
| From: | Nathan Scott <nscott@xxxxxxxxxx> |
| Date: | Wed, 04 Oct 2006 08:17:19 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20061003050654.GQ4695059@xxxxxxxxxxxxxxxxx> |
| Organization: | Aconex |
| References: | <20061003050654.GQ4695059@xxxxxxxxxxxxxxxxx> |
| Reply-to: | nscott@xxxxxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Tue, 2006-10-03 at 15:06 +1000, David Chinner wrote: > In fixing the recent problems with inode use-after-free in > xfs_iunpin, we introduced a new deadlock. When iput() is called, it > can trigger new transactions on the inode if we are dropping the > final reference. This is a bad thing to do from a xfslogd because it > is theonly thread that can move the tail of the log forwards. *nod*, sounds reasonable & your fix looks good to me, Dave. cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: clean up inode i_flags handling, Nathan Scott |
|---|---|
| Next by Date: | Re: Review: clean up inode i_flags handling, Nathan Scott |
| Previous by Thread: | Review: prevent deadlock via async iput from xfs_iunpin, David Chinner |
| Next by Thread: | Review: clean up inode i_flags handling, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |