xfs
[Top] [All Lists]

Re: [RFC 0/3] Convert XFS inode hashes to radix trees

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [RFC 0/3] Convert XFS inode hashes to radix trees
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Tue, 3 Oct 2006 14:23:35 -0700
Cc: xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx, dhowells@xxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20061003060610.GV3024@xxxxxxxxxxxxxxxxx>
References: <20061003060610.GV3024@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Tue, Oct 03, 2006 at 04:06:10PM +1000, David Chinner wrote:

> Overall, the patchset removes more than 200 lines of code from the
> xfs inode caching and lookup code and provides more consistent
> scalability for large numbers of cached inodes. The only down side
> is that it limits us to 32 bit inode numbers of 32 bit platforms due
> to the way the radix tree uses unsigned longs for it's indexes

    commit afefdbb28a0a2af689926c30b94a14aea6036719
    tree 6ee500575cac928cd90045bcf5b691cf2b8daa09
    parent 1d32849b14bc8792e6f35ab27dd990d74b16126c
    author David Howells <dhowells@xxxxxxxxxx> 1159863226 -0700
    committer Linus Torvalds <torvalds@xxxxxxxxxxx> 1159887820 -0700

    [PATCH] VFS: Make filldir_t and struct kstat deal in 64-bit inode numbers

    These patches make the kernel pass 64-bit inode numbers internally when
    communicating to userspace, even on a 32-bit system.  They are required
    because some filesystems have intrinsic 64-bit inode numbers: NFS3+ and XFS
    for example.  The 64-bit inode numbers are then propagated to userspace
    automatically where the arch supports it.
    [...]

Doing this will mean XFS won't be able to support 32-bit inodes on
32-bit platforms the above (merged) patch --- though given that cheap
64-bit systems are now abundant does anyone really care?


<Prev in Thread] Current Thread [Next in Thread>