xfs
[Top] [All Lists]

Re: [PATCH 1/2] Make stuff static

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH 1/2] Make stuff static
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 16 Oct 2006 20:03:47 -0500
Cc: Russell Cattelan <cattelan@xxxxxxxxxxx>, Timothy Shimmin <tes@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20061017005038.GN11034@melbourne.sgi.com>
References: <20060929032856.8DA9C18001A5E@sandeen.net> <23F15D6AE8566A54B81188AC@timothy-shimmins-power-mac-g5.local> <45338DDE.8020903@sandeen.net> <4533FAEA.2080500@sandeen.net> <20061016232250.GM11034@melbourne.sgi.com> <1161042943.5723.117.camel@xenon.msp.redhat.com> <20061017005038.GN11034@melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.7 (Macintosh/20060909)
David Chinner wrote:

So you are proposing?
/* non-debug */
#define STATIC static inline
/* debug */
#define STATIC noinline

No.

Currently STATIC is defined in fs/xfs/support/debug.h as:

#ifndef STATIC
#define STATIC static
#endif

I'm proposing that gets changed to:

#define STATIC static noinline

This.

This sounds reasonable to me, David.

-Eric


<Prev in Thread] Current Thread [Next in Thread>