xfs
[Top] [All Lists]

Re: [PATCH 1/2] Make stuff static

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH 1/2] Make stuff static
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 16 Oct 2006 08:49:18 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <23F15D6AE8566A54B81188AC@timothy-shimmins-power-mac-g5.local>
References: <20060929032856.8DA9C18001A5E@sandeen.net> <23F15D6AE8566A54B81188AC@timothy-shimmins-power-mac-g5.local>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.7 (Macintosh/20060909)
Timothy Shimmin wrote:
Okay, started looking :-)

Some comments below...

--Tim

Thanks Tim! :)

--- xfs-linux.orig/linux-2.4/xfs_vnode.c
+++ xfs-linux/linux-2.4/xfs_vnode.c
@@ -17,7 +17,7 @@
 #include "xfs.h"

 uint64_t vn_generation;        /* vnode generation number */
-spinlock_t vnumber_lock = SPIN_LOCK_UNLOCKED;
+static spinlock_t vnumber_lock = SPIN_LOCK_UNLOCKED;


Not STATIC? Curious.

Yeah, probably should be; IIRC there were other "statics" in that file, was just following the convention. I'll make sure it builds OK w/ STATIC and send an updated patch (need to do that anyway).


Yep for all xfs_iext_ funcs.

Well actually it looks like xfs_bmap.c uses these:
--------------------
xfs_iext_add
xfs_iext_bno_to_ext
xfs_iext_get_ext
xfs_iext_insert
xfs_iext_remove
---------------------

So I'm not sure why some are still here...
xfs_iext_destroy

Exported... maybe you can tell me why? :)

xfs_iext_idx_to_irec

Same deal.

xfs_iext_realloc (only exists in header???)

Odd, missed that one, guess it can go too? Maybe others lurk as well.

Thanks!

-Eric

--Tim





<Prev in Thread] Current Thread [Next in Thread>