| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: clean up inode i_flags handling |
| From: | Nathan Scott <nscott@xxxxxxxxxx> |
| Date: | Wed, 04 Oct 2006 08:26:13 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20061003051325.GR4695059@melbourne.sgi.com> |
| Organization: | Aconex |
| References: | <20061003051325.GR4695059@melbourne.sgi.com> |
| Reply-to: | nscott@xxxxxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Tue, 2006-10-03 at 15:13 +1000, David Chinner wrote:
>
This part seems like overkill, I'd just do that inline like the clear
variant, since its just one instruction ...
+static inline void
+__xfs_iflags_set(xfs_inode_t *ip, unsigned short flags)
+{
+ ip->i_flags |= flags;
+}
Oh, ditto for the test inline func, I guess.
cheers.
--
Nathan
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Alert from eSafe: transcript.zip\transcript.html .pif Infected with Win32.Mydoom.m, esafe |
|---|---|
| Next by Date: | Re: Review: prevent deadlock via async iput from xfs_iunpin, Nathan Scott |
| Previous by Thread: | Review: clean up inode i_flags handling, David Chinner |
| Next by Thread: | Re: Review: clean up inode i_flags handling, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |