xfs
[Top] [All Lists]

Re: [PATCH 2/2] Remove unused stuff

To: sandeen@xxxxxxxxxxx
Subject: Re: [PATCH 2/2] Remove unused stuff
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 29 Sep 2006 12:06:02 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20060929032916.AB75B18001A5F@xxxxxxxxxxx>
References: <20060929032916.AB75B18001A5F@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.7 (X11/20060913)
sandeen@xxxxxxxxxxx wrote:
> And now that things are static, remove things that are not used.
> 
>  xfs_bmap.c       |   36 ------------------
>  xfs_bmap_btree.c |   74 -------------------------------------
>  xfs_bmap_btree.h |   11 -----
>  xfs_da_btree.c   |   15 -------
>  xfs_da_btree.h   |    1 
>  xfs_error.c      |   26 -------------
>  xfs_error.h      |    1 
>  xfs_rtalloc.c    |  108 
> -------------------------------------------------------
>  xfs_rtalloc.h    |   18 ---------
>  9 files changed, 290 deletions(-)
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>


I suppose that if this code is deemed useful, maybe it could be moved to
some xfs_*_debug.[ch] files so it's not lost....

Hm, or looks like some of it is used in userspace (xfs_da_log2_roundup)
it could be moved there if not ever used in the kernel.  (although from
a quick look I'm not sure that's doing anything useful there either,
anymore).

-Eric


<Prev in Thread] Current Thread [Next in Thread>