xfs
[Top] [All Lists]

Re: LVM and XFS cannot set blocksize on block device

To: Tim Shimmin <tes@xxxxxxx>
Subject: Re: LVM and XFS cannot set blocksize on block device
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Thu, 28 Sep 2006 08:32:18 -0700
Cc: Shailendra Tripathi <stripathi@xxxxxxxxx>, Rene Salmon <rsalmon@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>
In-reply-to: <451BA2AF.9090703@xxxxxxx>
References: <45185424.2030707@xxxxxxxxxx> <20060926001737.GA10224@xxxxxxxxxxxxxxxxxxxxx> <45193204.3030500@xxxxxxxxxx> <20060926224053.GA31542@xxxxxxxxxxxxxxxxxxxxx> <451A669D.9020503@xxxxxxxxx> <451BA2AF.9090703@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Thu, Sep 28, 2006 at 08:23:43PM +1000, Tim Shimmin wrote:

> I'll have a look soon at passing the mkfs.xfs -s option thru to
> libxfs which is consistent with the existing code.

(following up on something mentioned off the list)

When you do this change please consider *not* making the code fallback
to a different blocksize if the ioctl fails when "-s size=" is given.

The logic here is that if someone clearly wants a specific value and
if that cannot be met it should error out with a suitable message, not
silently do something else.


<Prev in Thread] Current Thread [Next in Thread>