xfs
[Top] [All Lists]

Re: review: minor cleanup in xfs_read locking

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: review: minor cleanup in xfs_read locking
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Mon, 04 Sep 2006 01:31:54 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20060904101711.A3331169@xxxxxxxxxxxxxxxxxxxxxxxx>
Organization: SGI
References: <20060904101711.A3331169@xxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: lachlan@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.7.12) Gecko/20050920
Looks good Nathan.

I've made changes to check return codes from bhv_vop_flushinval_pages()
and friends so it's now dependent on this change.  I'll post a review
as soon as your change has gone in.

Nathan Scott wrote:
Hi Lachlan,

Could you check this for me - it just folds the second direct I/O
conditional added in your recent deadlock fix back into the prior
branch, which is also direct I/O specific...

thanks.



<Prev in Thread] Current Thread [Next in Thread>