Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs

xfs

Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2]

To:	Masayuki Saito <m-saito@xxxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2]
From:	Andrew Morton <akpm@xxxxxxxx>
Date:	Wed, 23 Aug 2006 21:38:17 -0700
Cc:	Nathan Scott <nathans@xxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20060823201251m-saito@xxxxxxxxxxxxxxxxxxxxxxx>
References:	<20060823201251m-saito@xxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx

On Wed, 23 Aug 2006 20:12:51 +0900
Masayuki Saito <m-saito@xxxxxxxxxxxxxx> wrote:

> It is the problem that i_flags of xfs_inode has no consistent
> locking protection.
> 
> For the reason, I define a new spin_lock(i_flags_lock) for i_flags
> of xfs_inode.  And I add this spin_lock for appropriate places.

You could simply use inode.i_lock for this.  i_lock is a general-purpose
per-inode lock.  Its mandate is "use it for whatever you like, but it must
always be `innermost'"

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Masayuki Saito Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Andrew Morton <= Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Nathan Scott Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Nathan Scott

Previous by Date:	Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Nathan Scott
Next by Date:	Re: [PATCH 2/2] Fix i_state of inode is changed after the inode is freed [try #2], Nathan Scott
Previous by Thread:	[PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Masayuki Saito
Next by Thread:	Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2], Nathan Scott
Indexes:	[Date] [Thread] [Top] [All Lists]