Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibl

xfs

Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibl

To:	"Nathan Scott" <nathans@xxxxxxx>
Subject:	Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int())
From:	"Jesper Juhl" <jesper.juhl@xxxxxxxxx>
Date:	Wed, 16 Aug 2006 23:05:59 +0200
Cc:	"Eric Sandeen" <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rxxYU/+VbKyv9LpOX0R4rLHJS2wsXz4IEGtYAXvT67Tn7BRCPWf5HYnlwXwvtijae352Sht9AxZD6ujBSY7Q/sXKSDyxuEcGypZ84OAXs1nMRzV+FxRQuukfBg15fHgdK6+xpcPqGsjwnRmUf6pjWWuttLaXUbhWAevLIISkSoc=
In-reply-to:	<20060814155609.G2698880@xxxxxxxxxxxxxxxxxxxxxxxx>
References:	<200608122334.21901.jesper.juhl@xxxxxxxxx> <44DE9B86.90006@xxxxxxxxxxx> <20060814155609.G2698880@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx

On 14/08/06, Nathan Scott <nathans@xxxxxxx> wrote:

On Sat, Aug 12, 2006 at 10:24:54PM -0500, Eric Sandeen wrote:
> ...
> FWIW seems like there's a lot of unnecessary endian flipping in there too; I
> haven't tested this but since it endian-flips the magic into blk->magic seems
> like it may as well use it:

How's this look?

As far as I can see it looks good, but I'm still just starting to read
the XFS code, so I'm far from reliable yet  ;-)

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int(), Jesper Juhl Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int(), Eric Sandeen review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Nathan Scott Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Eric Sandeen Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Jesper Juhl <=

Previous by Date:	Re: xfsdump -s unacceptable performances, Daniele P.
Next by Date:	xfs for Oracle, Jeffrey Bryson
Previous by Thread:	Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Eric Sandeen
Next by Thread:	[PMX:VIRUS] Returned mail: Data format error, pop-group-owner
Indexes:	[Date] [Thread] [Top] [All Lists]