Re: review: fsblock zero - don't panic

[Nathan Scott <nathans@xxxxxxx>]

On Wed, Aug 16, 2006 at 04:47:25PM +1000, David Chinner wrote:
> On Wed, Aug 16, 2006 at 02:28:01PM +1000, Nathan Scott wrote:
> ...
>               xfs_cmn_err_fsblock_zero(ip, ret_imap);
> 
> would replace the above mess....

Will do.

> > -   if (!(io->io_flags & XFS_IOCORE_RT)  && !ret_imap->br_startblock) {
> 
> And this one checks ret_imap for block zero, not imap[0].
> 
> One of these original checks was buggy - which one should we be checking,
> ret_imap that is being passed into the function or imap that is what was
> returned  by the XFS_BMAPI call?

The latter I think - I'll look more closely tomorrow, and fix that up.

cheers.

-- 
Nathan