| To: | Nathan Scott <nathans@xxxxxxx> |
|---|---|
| Subject: | Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()) |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Mon, 14 Aug 2006 11:00:06 -0500 |
| Cc: | Jesper Juhl <jesper.juhl@xxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20060814155609.G2698880@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <200608122334.21901.jesper.juhl@xxxxxxxxx> <44DE9B86.90006@xxxxxxxxxxx> <20060814155609.G2698880@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 1.5.0.4 (X11/20060614) |
Nathan Scott wrote: On Sat, Aug 12, 2006 at 10:24:54PM -0500, Eric Sandeen wrote:...FWIW seems like there's a lot of unnecessary endian flipping in there too; I haven't tested this but since it endian-flips the magic into blk->magic seems like it may as well use it:How's this look? Looks good to me.(now that I look closer & grok that there are 2 loops in that function and the break is in the nested one... oops!) -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: cache_purge: shake on cache 0x5880a0 left 8 nodes!?, Paul Slootman |
|---|---|
| Next by Date: | RE: cache_purge: shake on cache 0x5880a0 left 8 nodes!?, Barry Naujok |
| Previous by Thread: | review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Nathan Scott |
| Next by Thread: | Re: review: cleanup xfs_da_node_lookup_int (was Re: [PATCH] XFS: possibly uninitialized variable use in fs/xfs/xfs_da_btree.c::xfs_da_node_lookup_int()), Jesper Juhl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |