xfs
[Top] [All Lists]

Re: review: Simple patch to remove the dmapi support from xfsdump

To: Russell Cattelan <cattelan@xxxxxxxxxxx>
Subject: Re: review: Simple patch to remove the dmapi support from xfsdump
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Mon, 7 Aug 2006 08:52:48 -0700
Cc: Dean Roehrich <dean.roehrich@xxxxxxx>, Bill Kendall <wkendall@xxxxxxx>, Vlad Apostolov <vapo@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <44D75C87.8050402@xxxxxxxxxxx>
References: <44D10F9B.8090904@xxxxxxxxxxx> <44D2CA85.3040208@xxxxxxx> <20060804141012.GA26@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <44D36985.1090006@xxxxxxxxxxx> <20060804155850.GA3338@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <44D379A6.9040200@xxxxxxx> <44D38D34.1010503@xxxxxxxxxxx> <44D3C351.7060109@xxxxxxx> <20060807150324.GA8421@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <44D75C87.8050402@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Mon, Aug 07, 2006 at 10:30:15AM -0500, Russell Cattelan wrote:

> It seems rather dangerous to have a #define floating around that
> could potentially get out of sync with the original, especially if
> you transport the number and not the enum table. (It make it really
> hard for cscope to find :-)

If it saves a header I don't see any harm in the original approach
with a comment preceding it explain what the bits are and why not to
screw them up.


<Prev in Thread] Current Thread [Next in Thread>