xfs
[Top] [All Lists]

TAKE 947312 - fix bma.conv assignment

To: linux-xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 947312 - fix bma.conv assignment
From: nathans@xxxxxxx (Nathan Scott)
Date: Wed, 30 Aug 2006 09:08:05 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Fix char size overflow in bmap_alloc call for unwritten extent conversion.

Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
always assigned zero.  Spotted by the GNU C compiler (SVN version).

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>


Date:  Wed Aug 30 09:06:53 AEST 2006
Workarea:  chook.melbourne.sgi.com:/build/nathans/xfs-linux
Inspected by:  Adrian Bunk <bunk@xxxxxxxxx>

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/xfs-kern/xfs-linux-melb


Modid:  xfs-linux-melb:xfs-kern:26887a
xfs_bmap.c - 1.358 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap.c.diff?r1=text&tr1=1.358&r2=text&tr2=1.357&f=h
        - Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
          always assigned zero.  Spotted by the GNU C compiler (SVN version).



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 947312 - fix bma.conv assignment, Nathan Scott <=