| To: | Russell Cattelan <cattelan@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: review: Simple patch to remove the dmapi support from xfsdump |
| From: | Chris Wedgwood <cw@xxxxxxxx> |
| Date: | Mon, 7 Aug 2006 08:52:48 -0700 |
| Cc: | Dean Roehrich <dean.roehrich@xxxxxxx>, Bill Kendall <wkendall@xxxxxxx>, Vlad Apostolov <vapo@xxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <44D75C87.8050402@thebarn.com> |
| References: | <44D10F9B.8090904@thebarn.com> <44D2CA85.3040208@sgi.com> <20060804141012.GA26@kickball-mn.Central.Sun.COM> <44D36985.1090006@thebarn.com> <20060804155850.GA3338@kickball-mn.Central.Sun.COM> <44D379A6.9040200@sgi.com> <44D38D34.1010503@thebarn.com> <44D3C351.7060109@sgi.com> <20060807150324.GA8421@kickball-mn.Central.Sun.COM> <44D75C87.8050402@thebarn.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Mon, Aug 07, 2006 at 10:30:15AM -0500, Russell Cattelan wrote: > It seems rather dangerous to have a #define floating around that > could potentially get out of sync with the original, especially if > you transport the number and not the enum table. (It make it really > hard for cscope to find :-) If it saves a header I don't see any harm in the original approach with a comment preceding it explain what the bits are and why not to screw them up. |
| Previous by Date: | Re: review: Simple patch to remove the dmapi support from xfsdump, Russell Cattelan |
|---|---|
| Next by Date: | Re: review: Simple patch to remove the dmapi support from xfsdump, Dean Roehrich |
| Previous by Thread: | Re: review: Simple patch to remove the dmapi support from xfsdump, Russell Cattelan |
| Next by Thread: | Re: review: Simple patch to remove the dmapi support from xfsdump, Dean Roehrich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |