xfs
[Top] [All Lists]

Re: [PATCH] kill leftover WANT_FUNCS macro indirection

To: Andi Kleen <ak@xxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] kill leftover WANT_FUNCS macro indirection
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 29 Jul 2006 17:23:05 -0500
In-reply-to: <p73k65w41je.fsf@xxxxxxxxxxxxx>
References: <44CAE247.6020608@xxxxxxxxxxx> <p73k65w41je.fsf@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.5 (Macintosh/20060719)
Andi Kleen wrote:
Eric Sandeen <sandeen@xxxxxxxxxxx> writes:

This gets rid of some pointless macro defines... I had a version that
lower-cased it all too but Nathan liked this better, and he's the man!
:)

Shouted function names is not exactly Linux code style at least.

-Andi


well, *shrug* I have both versions, Nathan can take his pick :)

honestly, one-liner static inlines isn't exactly linux code style either, tho the typechecking is nice.

I guess I shouldn't have said "Nathan liked this better" - I think he was being pragmatic about the scope of the change.

-Eric


<Prev in Thread] Current Thread [Next in Thread>