xfs
[Top] [All Lists]

Re: review: fix bulkstat error detection logic

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: review: fix bulkstat error detection logic
From: Nathan Scott <nathans@xxxxxxx>
Date: Fri, 28 Jul 2006 15:45:58 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <44C9A353.1050702@xxxxxxx>; from tes@xxxxxxx on Fri, Jul 28, 2006 at 03:40:35PM +1000
References: <20060726102406.I2118045@xxxxxxxxxxxxxxxxxxxxxxxx> <44C9A353.1050702@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, Jul 28, 2006 at 03:40:35PM +1000, Timothy Shimmin wrote:
> Looks reasonable.
> So you still do the inode buffer validation but we don't print out
> a corruption error msg and we return EINVAL instead of EFSCORRUPTED.

Right.

> Can we not be bulkstat'ing over inodes with reasonable numbers/locations but
> the inode data on disk is just corrupted?

Yes, we can, but we don't want bulkstat to shutdown the filesystem
in that situation.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>