xfs
[Top] [All Lists]

Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_t

To: Josh Triplett <josht@xxxxxxxxxx>
Subject: Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete_ail
From: Nathan Scott <nathans@xxxxxxx>
Date: Fri, 28 Jul 2006 09:20:36 +1000
Cc: linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1153938323.12517.58.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>; from josht@xxxxxxxxxx on Wed, Jul 26, 2006 at 11:25:23AM -0700
References: <1153938323.12517.58.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Wed, Jul 26, 2006 at 11:25:23AM -0700, Josh Triplett wrote:
> xfs_trans_update_ail and xfs_trans_delete_ail get called with the AIL lock
> held, and release it.  Add lock annotations to these two functions (abstracted
> like the AIL lock itself) so that sparse can check callers for lock pairing,
> and so that sparse will not complain about these functions since they
> intentionally use locks in this manner.

Thanks Josh, looks good - I'll get it merged.  I'd prefer to just
open code the use of __acquires/__releases for clarity, but I can
easily make that change before merging.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete_ail, Nathan Scott <=