[Top] [All Lists]

Re: review: rework bulkstat readahead

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: review: rework bulkstat readahead
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Jul 2006 10:38:42 +0100
Cc: vapo@xxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20060725134651.D2116482@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20060725134651.D2116482@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/
On Tue, Jul 25, 2006 at 01:46:51PM +1000, Nathan Scott wrote:
> Hi all,
> This patch rearranges the logic inside xfs_bulkstat to issue
> readahead in a way that performs alot better.  The most critical 
> piece is moving the readahead out of the final read-and-format
> loop into the earlier build-up-irbuf-array loop.  This means:
> - buffer readaheads are all issued at once, up front, before we 
> start to issue the blocking reads waiting on each inode cluster;
> - as a by-product, the readahead which is done for the internal
> nodes of the AGI btree (from within xfs_inobt_increment) is now 
> issued in the correct order relative to all the leaf readahead. 
> I've also removed the incorrect endian swapping on the irbuf array
> elements, that was always unnecessary as they're only ever held in
> memory here.

looks good and sorry for not noticing the unessecary swapping when doing
the sparse annotations.

<Prev in Thread] Current Thread [Next in Thread>