xfs
[Top] [All Lists]

Re: [PATCH] xfs: remove unused locking flags

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: [PATCH] xfs: remove unused locking flags
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 9 Jul 2006 13:56:43 +0100
Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20060709105454.D1640104@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20060708215324.GA7522@xxxxxxxxxxxxxxxxxxxxxx> <20060709105454.D1640104@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Sun, Jul 09, 2006 at 10:54:54AM +1000, Nathan Scott wrote:
> On Sun, Jul 09, 2006 at 01:53:24AM +0400, Alexey Dobriyan wrote:
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> 
> NACK.  These macros get used by other SGI code (not merged in mainline).
> Their presence here has zero runtime cost, and keeps merges simpler for
> me, so they need to stay.
> 
> Thanks for the cleanup patches though, keep 'em coming.

I don't think theres a valid reason to keep such dead code around.  If
you want these flags to stay merge the code in mainline.  And while we're
at that it would be nice if git tree merges would go via -fsdevel with
a full set of patches.  There seem to be some rather odd things creeping
in lately.


<Prev in Thread] Current Thread [Next in Thread>