| To: | Alexey Dobriyan <adobriyan@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: move XFS_IOC_GETVERSION to main multiplexer |
| From: | Nathan Scott <nathans@xxxxxxx> |
| Date: | Sun, 9 Jul 2006 10:50:14 +1000 |
| Cc: | Andrew Morton <akpm@xxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20060708181252.GA8091@xxxxxxxxxxxxxxxxxxxxxx>; from adobriyan@xxxxxxxxx on Sat, Jul 08, 2006 at 10:12:52PM +0400 |
| References: | <20060708181252.GA8091@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5i |
On Sat, Jul 08, 2006 at 10:12:52PM +0400, Alexey Dobriyan wrote: > * Don't do inode => vnode => inode conversion, use passed inode directly > * Don't allocate and free memory on each call > * As a consequence, don't have a chance to return ENOMEM, which would be > truly bizarre error code for this ioctl. Yoohoo, I'm over here... send XFS patches to me please. Thats the second time I've asked you that... is there a problem there? > + return put_user(inode->i_generation, (int __user *)arg); > + Looks fine, I'll merge it when I'm in the office tomorrow. You've tested this change, right? cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Delhi IT Directory - 2006, CRM4BUSINESS |
|---|---|
| Next by Date: | Re: [PATCH] xfs: remove unused locking flags, Nathan Scott |
| Previous by Thread: | [PATCH] xfs: move XFS_IOC_GETVERSION to main multiplexer, Alexey Dobriyan |
| Next by Thread: | Output of mkfs.xfs su/sw values don't match the command line su/sw values, Brian Davis |
| Indexes: | [Date] [Thread] [Top] [All Lists] |