xfs
[Top] [All Lists]

Buglet in mount(8) with large page size

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: Buglet in mount(8) with large page size
From: Nathan Scott <nathans@xxxxxxx>
Date: Mon, 24 Jul 2006 10:23:59 +1000
Cc: Arthur Corliss <acorliss@xxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Adrian,

We have had this XFS bug report...
        http://oss.sgi.com/bugzilla/show_bug.cgi?id=704
...and Arthur has diagnosed the problem and proposed a fix.

Its in some code we "lifted" from mount(8) to attempt to detect
an existing filesystem/partition/... before overwriting it with
mkfs.xfs.

How do you want to fix this in mount_guess_fstype.c?  Options
would seem to be:
- bump up the size of the "buf" array to cater for all current
page sizes; or
- malloc the read buffer taking into account the page size.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>
  • Buglet in mount(8) with large page size, Nathan Scott <=