[Top] [All Lists]

Re: review: fix remount vs barrier options

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: review: fix remount vs barrier options
From: Timothy Shimmin <tes@xxxxxxx>
Date: Fri, 21 Jul 2006 16:25:59 +1000
Cc: xfs@xxxxxxxxxxx, jeremy@xxxxxxx
In-reply-to: <20060721152807.D1998769@wobbly.melbourne.sgi.com>
References: <20060721152807.D1998769@wobbly.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.8 (X11/20060411)
Nathan Scott wrote:

Jeremy has had me scratching my head for a few days trying to
figure out how the SCSI traces he's looking at can still show
signs of write barriers being issued to the device, despite a
"remount,nobarrier" having been done.

It finally clicked that we are not clearing the buffer flag
from a previously written log buffer, even though we'll no
longer set a new flag into a buffer (due to the mount flag
being cleared), so we _can_ still issue barrier writes when
remounted without barriers.

This was made more complicated by the way a freshly mounted
filesystem with 8 log buffers wouldn't show up the problem,
since we have to slowly cycle through the "clear" log buffers
before we see the bug.  This seems like the simplest fix...

(Hmmm, actually, I wonder if this will also resolve the quota
log I/O problem that was reported the other day too).

Patch looks good to me.


<Prev in Thread] Current Thread [Next in Thread>