xfs
[Top] [All Lists]

[PATCH 3/7] xfs: remove left over INT_ comments in *alloc*.c

To: nathans@xxxxxxx
Subject: [PATCH 3/7] xfs: remove left over INT_ comments in *alloc*.c
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 10 Jul 2006 19:04:15 +0200
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
We can verify endianess handling with sparse now, no need for comments.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs-2.6.x/fs/xfs/xfs_alloc_btree.c
===================================================================
--- xfs-2.6.x.orig/fs/xfs/xfs_alloc_btree.c     2006-07-09 19:28:15.000000000 
+0200
+++ xfs-2.6.x/fs/xfs/xfs_alloc_btree.c  2006-07-09 19:34:56.000000000 +0200
@@ -774,7 +774,7 @@
                 * Now stuff the new record in, bump numrecs
                 * and log the new data.
                 */
-               rp[ptr - 1] = *recp; /* INT_: struct copy */
+               rp[ptr - 1] = *recp;
                be16_add(&block->bb_numrecs, 1);
                xfs_alloc_log_recs(cur, bp, ptr, 
be16_to_cpu(block->bb_numrecs));
 #ifdef DEBUG
@@ -819,8 +819,8 @@
         */
        *bnop = nbno;
        if (nbno != NULLAGBLOCK) {
-               *recp = nrec; /* INT_: struct copy */
-               *curp = ncur; /* INT_: struct copy */
+               *recp = nrec;
+               *curp = ncur;
        }
        *stat = 1;
        return 0;
@@ -1229,7 +1229,7 @@
                if ((error = xfs_btree_check_sptr(cur, be32_to_cpu(*rpp), 
level)))
                        return error;
 #endif
-               *lpp = *rpp; /* INT_: copy */
+               *lpp = *rpp;
                xfs_alloc_log_ptrs(cur, lbp, nrec, nrec);
                xfs_btree_check_key(cur->bc_btnum, lkp - 1, lkp);
        }
@@ -1406,8 +1406,8 @@
 
                kp = XFS_ALLOC_KEY_ADDR(new, 1, cur);
                if (be16_to_cpu(left->bb_level) > 0) {
-                       kp[0] = *XFS_ALLOC_KEY_ADDR(left, 1, cur); /* INT_: 
structure copy */
-                       kp[1] = *XFS_ALLOC_KEY_ADDR(right, 1, cur);/* INT_: 
structure copy */
+                       kp[0] = *XFS_ALLOC_KEY_ADDR(left, 1, cur);
+                       kp[1] = *XFS_ALLOC_KEY_ADDR(right, 1, cur);
                } else {
                        xfs_alloc_rec_t *rp;    /* btree record pointer */
 
@@ -1527,8 +1527,8 @@
                if ((error = xfs_btree_check_sptr(cur, be32_to_cpu(*lpp), 
level)))
                        return error;
 #endif
-               *rkp = *lkp; /* INT_: copy */
-               *rpp = *lpp; /* INT_: copy */
+               *rkp = *lkp;
+               *rpp = *lpp;
                xfs_alloc_log_keys(cur, rbp, 1, be16_to_cpu(right->bb_numrecs) 
+ 1);
                xfs_alloc_log_ptrs(cur, rbp, 1, be16_to_cpu(right->bb_numrecs) 
+ 1);
                xfs_btree_check_key(cur->bc_btnum, rkp, rkp + 1);
Index: xfs-2.6.x/fs/xfs/xfs_ialloc_btree.c
===================================================================
--- xfs-2.6.x.orig/fs/xfs/xfs_ialloc_btree.c    2006-07-09 19:34:52.000000000 
+0200
+++ xfs-2.6.x/fs/xfs/xfs_ialloc_btree.c 2006-07-09 19:34:56.000000000 +0200
@@ -681,7 +681,7 @@
                if ((error = xfs_btree_check_sptr(cur, *bnop, level)))
                        return error;
 #endif
-               kp[ptr - 1] = key; /* INT_: struct copy */
+               kp[ptr - 1] = key;
                pp[ptr - 1] = cpu_to_be32(*bnop);
                numrecs++;
                block->bb_numrecs = cpu_to_be16(numrecs);
@@ -698,7 +698,7 @@
                 * Now stuff the new record in, bump numrecs
                 * and log the new data.
                 */
-               rp[ptr - 1] = *recp; /* INT_: struct copy */
+               rp[ptr - 1] = *recp;
                numrecs++;
                block->bb_numrecs = cpu_to_be16(numrecs);
                xfs_inobt_log_recs(cur, bp, ptr, numrecs);
@@ -731,7 +731,7 @@
         */
        *bnop = nbno;
        if (nbno != NULLAGBLOCK) {
-               *recp = nrec; /* INT_: struct copy */
+               *recp = nrec;
                *curp = ncur;
        }
        *stat = 1;
@@ -1117,7 +1117,7 @@
                if ((error = xfs_btree_check_sptr(cur, be32_to_cpu(*rpp), 
level)))
                        return error;
 #endif
-               *lpp = *rpp; /* INT_: no-change copy */
+               *lpp = *rpp;
                xfs_inobt_log_ptrs(cur, lbp, nrec, nrec);
        }
        /*
@@ -1297,8 +1297,8 @@
         */
        kp = XFS_INOBT_KEY_ADDR(new, 1, cur);
        if (be16_to_cpu(left->bb_level) > 0) {
-               kp[0] = *XFS_INOBT_KEY_ADDR(left, 1, cur); /* INT_: struct copy 
*/
-               kp[1] = *XFS_INOBT_KEY_ADDR(right, 1, cur); /* INT_: struct 
copy */
+               kp[0] = *XFS_INOBT_KEY_ADDR(left, 1, cur);
+               kp[1] = *XFS_INOBT_KEY_ADDR(right, 1, cur);
        } else {
                rp = XFS_INOBT_REC_ADDR(left, 1, cur);
                kp[0].ir_startino = rp->ir_startino;
@@ -1410,8 +1410,8 @@
                if ((error = xfs_btree_check_sptr(cur, be32_to_cpu(*lpp), 
level)))
                        return error;
 #endif
-               *rkp = *lkp; /* INT_: no change copy */
-               *rpp = *lpp; /* INT_: no change copy */
+               *rkp = *lkp;
+               *rpp = *lpp;
                xfs_inobt_log_keys(cur, rbp, 1, be16_to_cpu(right->bb_numrecs) 
+ 1);
                xfs_inobt_log_ptrs(cur, rbp, 1, be16_to_cpu(right->bb_numrecs) 
+ 1);
        } else {


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 3/7] xfs: remove left over INT_ comments in *alloc*.c, Christoph Hellwig <=