xfs
[Top] [All Lists]

TAKE 951958 - Regression in bonnie++ due to messed up nused counter in x

To: sgi.bugs.snlinux@xxxxxxx, sgi.bugs.xfs@xxxxxxx, xfs@xxxxxxx
Subject: TAKE 951958 - Regression in bonnie++ due to messed up nused counter in xfs_dir2_free_hdr_t
From: alkirkco@xxxxxxx (Mandy Miklos)
Date: Tue, 6 Jun 2006 22:23:43 -0500 (CDT)
Sender: xfs-bounce@xxxxxxxxxxx
Fix nused counter.  It's currently getting set to -1 rather than getting
decremented by 1.  Since nused never reaches 0, the "if (!free->hdr.nused)"
check in xfs_dir2_leafn_remove() fails every time and xfs_dir2_shrink_inode()
doesn't get called when it should.  This causes extra blocks to be left on
an empty directory and the directory in unable to be converted back to
inline extent mode.

Date:  Tue Jun  6 20:21:01 PDT 2006
Workarea:  
attica.americas.sgi.com:/data/lwork/attica2/alkirkco/XFS/2.6.x-xfs-i386
Inspected by:  nathans

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/linux/2.6.x-xfs


Modid:  xfs-linux:xfs-kern:211382a
fs/xfs/xfs_dir2_node.c - 1.56 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_dir2_node.c.diff?r1=text&tr1=1.56&r2=text&tr2=1.55&f=h
        - Fix nused counter to get decremented by 1 rather than set to -1.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 951958 - Regression in bonnie++ due to messed up nused counter in xfs_dir2_free_hdr_t, Mandy Miklos <=