xfs
[Top] [All Lists]

Re: [XFSDUMP PATCH] Fixes for parallel compiles

To: "Robin H. Johnson" <robbat2@xxxxxxxxxx>
Subject: Re: [XFSDUMP PATCH] Fixes for parallel compiles
From: Bill Kendall <wkendall@xxxxxxx>
Date: Wed, 21 Jun 2006 19:00:12 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20060611195156.GF26475@curie-int.vc.shawcable.net>
References: <20060611195156.GF26475@curie-int.vc.shawcable.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051011)
Hi Robin,

Your suggested makefile changes have gone into xfsdump 2.2.39.

Thanks,
Bill

Robin H. Johnson wrote:
Several of the directories in xfsdump are not parallel compile safe, due to
their behavior of deleting and symlinking heads from other directories.

This patch modifies those Makefiles to have the symlinks be a dependancy of the
source in those directories, ensuring that all of the symlinks will exist
before the actual compiling is started.

Signed-off-by: Robin H. Johnson <robbat2@xxxxxxxxxx>

diff -Nuar --exclude '*.orig' --exclude builddefs.in xfsdump-2.2.33/dump/Makefile xfsdump-2.2.33/dump/Makefile
--- xfsdump-2.2.33/dump/Makefile 2006-01-11 21:06:47.000000000 -0800
+++ xfsdump-2.2.33/dump/Makefile 2006-06-11 12:36:21.436682241 -0700
@@ -102,7 +102,9 @@
install-dev:
$(COMMINCL) $(COMMON):
- @$(RM) $@; $(LN_S) ../common/$@ $@
+ $(RM) $@; $(LN_S) ../common/$@ $@
$(INVINCL) $(INVCOMMON):
- @$(RM) $@; $(LN_S) ../inventory/$@ $@
+ $(RM) $@; $(LN_S) ../inventory/$@ $@
+
+$(LOCALS): $(LINKS)
diff -Nuar --exclude '*.orig' --exclude builddefs.in xfsdump-2.2.33/invutil/Makefile xfsdump-2.2.33/invutil/Makefile
--- xfsdump-2.2.33/invutil/Makefile 2006-01-11 21:06:48.000000000 -0800
+++ xfsdump-2.2.33/invutil/Makefile 2006-06-11 12:36:21.438682223 -0700
@@ -66,7 +66,9 @@
install-dev:
$(COMMINCL) $(COMMON):
- @$(RM) $@; $(LN_S) ../common/$@ $@
+ $(RM) $@; $(LN_S) ../common/$@ $@
$(INVINCL) $(INVCOMMON):
- @$(RM) $@; $(LN_S) ../inventory/$@ $@
+ $(RM) $@; $(LN_S) ../inventory/$@ $@
+
+$(LOCALS): $(LINKS)
diff -Nuar --exclude '*.orig' --exclude builddefs.in xfsdump-2.2.33/restore/Makefile xfsdump-2.2.33/restore/Makefile
--- xfsdump-2.2.33/restore/Makefile 2006-01-11 21:06:49.000000000 -0800
+++ xfsdump-2.2.33/restore/Makefile 2006-06-11 12:36:21.433682268 -0700
@@ -112,7 +112,9 @@
install-dev:
$(COMMINCL) $(COMMON):
- @$(RM) $@; $(LN_S) ../common/$@ $@
+ $(RM) $@; $(LN_S) ../common/$@ $@
$(INVINCL) $(INVCOMMON):
- @$(RM) $@; $(LN_S) ../inventory/$@ $@
+ $(RM) $@; $(LN_S) ../inventory/$@ $@
+
+$(LOCALS): $(LINKS)




<Prev in Thread] Current Thread [Next in Thread>