xfs
[Top] [All Lists]

Re: mkfs.xfs in xfsprogs-2.7.11 is broken on FreeBSD?

To: Russell Cattelan <cattelan@xxxxxxxxxxx>
Subject: Re: mkfs.xfs in xfsprogs-2.7.11 is broken on FreeBSD?
From: Nathan Scott <nathans@xxxxxxx>
Date: Sat, 27 May 2006 05:49:58 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <447756D7.80300@xxxxxxxxxxx>; from cattelan@xxxxxxxxxxx on Fri, May 26, 2006 at 02:28:23PM -0500
References: <20060526122952.GA1639@xxxxxxxxxxxxxx> <447756D7.80300@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, May 26, 2006 at 02:28:23PM -0500, Russell Cattelan wrote:
> 
> Yup that is because xfs_arch.h is not correctly detecting the host 
> endianness,
> so all the filesystems created by mkfs are defaulting to native byte 
> ordering.
> ...
> Including the changes I have currently but we probably need to
> move the endian checking to xfs_freebsd.h and then have
> xfs_arch.h pick up an XFS defined var.

After a bit more digging, it seems the BSDs use macros without
the leading "__" - I'll get this all fixed up shortly.

> Ohh also note the incorrect use of strcpy vs strcmp.

*cough* ... er, yes, that too I'll merge in. :)

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>