xfs
[Top] [All Lists]

TAKE 953263 - bug in recovery processing of unlinked list

To: linux-xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 953263 - bug in recovery processing of unlinked list
From: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 26 May 2006 13:30:20 +1000 (AEST)
Sender: xfs-bounce@xxxxxxxxxxx
We were over zealous with doing endian conversions.
We endian converted the logged version of di_next_unlinked which
is actually always stored in the correct ondisk format.
This was pointed out to us by Shailendra Tripathi.
The bug is evident in the xfs qa test of 121.

--Tim

Date:  Fri May 26 13:28:27 AEST 2006
Workarea:  snort.melbourne.sgi.com:/home/tes/isms/xfs-linux
Inspected by:  stripathi@xxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/xfs-kern/xfs-linux-melb


Modid:  xfs-linux-melb:xfs-kern:26044a
xfs_log_recover.c - 1.309 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log_recover.c.diff?r1=text&tr1=1.309&r2=text&tr2=1.308&f=h
        - We endian converted the logged version of di_next_unlinked which
          is actually always stored in the correct ondisk format.
          Bug and solution reported by stripathi@xxxxxxxxxx
          Go back to original IRIX line for this.


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 953263 - bug in recovery processing of unlinked list, Timothy Shimmin <=