| To: | Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: Parenthesize macros in xfs |
| From: | Andreas Schwab <schwab@xxxxxxx> |
| Date: | Sun, 26 Mar 2006 16:23:12 +0200 |
| Cc: | Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <Pine.LNX.4.61.0603261124320.22145@xxxxxxxxxxxxxxx> (Jan Engelhardt's message of "Sun, 26 Mar 2006 11:26:41 +0200 (MEST)") |
| References: | <Pine.LNX.4.61.0603202207310.20060@xxxxxxxxxxxxxxx> <20060321082327.B653275@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0603202239110.11933@xxxxxxxxxxxxxxx> <20060321084619.E653275@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0603252232570.18484@xxxxxxxxxxxxxxx> <je1wwq2lqn.fsf@xxxxxxxxxxxxx> <Pine.LNX.4.61.0603260023070.12891@xxxxxxxxxxxxxxx> <jewtei1434.fsf@xxxxxxxxxxxxx> <Pine.LNX.4.61.0603261124320.22145@xxxxxxxxxxxxxxx> |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
| User-agent: | Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) |
Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes: >>>>> + swapfunc(a, b, es, swaptype) \ >>>>> +} while(0) >>>> ^^ >>>>Missing semicolon. >>> >>> It was missing before too. ;) >> >>No, previously it was provided at the call site. > > Bad habit IMO. It does not hurt to provide it in both the macro and > the call site, GCC can handle empty instructions. There is no way to provide the missing semicolon at the call site. swapfunc can't provide it either, since it's not a macro. Andreas. -- Andreas Schwab, SuSE Labs, schwab@xxxxxxx SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Could not allocate buf during xfs_fsr?, Justin Piszcz |
|---|---|
| Next by Date: | Re: Could not allocate buf during xfs_fsr?, Ralf Hildebrandt |
| Previous by Thread: | Re: Parenthesize macros in xfs, Jan Engelhardt |
| Next by Thread: | Re: Parenthesize macros in xfs, Jan Engelhardt |
| Indexes: | [Date] [Thread] [Top] [All Lists] |